RFR: 8344942: Template-Based Testing Framework [v7]

Emanuel Peter epeter at openjdk.org
Wed May 7 12:03:12 UTC 2025


On Wed, 7 May 2025 09:07:16 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   typo
>
> test/hotspot/jtreg/compiler/lib/template_framework/Template.java line 59:
> 
>> 57:  * string with hashtag {@code #} "holes" that are then replaced by the template arguments and the
>> 58:  * {@link #let} definitions.
>> 59:  *
> 
> Should we also insert `<p>` between the snippets? Same further down at method comments.

Ah nice catch! I put them in at the beginning, but then expanded the documentation and forgot it there.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2077464122


More information about the hotspot-compiler-dev mailing list