RFR: 8344942: Template-Based Testing Framework [v9]

Emanuel Peter epeter at openjdk.org
Wed May 7 12:29:21 UTC 2025


On Wed, 7 May 2025 11:45:46 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
>> 
>>  - Merge branch 'master' into JDK-8344942-TemplateFramework-v3
>>  - Whitespace
>>  - Suggestions by Christian
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>  - typo
>>  - For Christian: example and more intro
>>  - fix hashtag
>>  - manual merge
>>  - Apply suggestions from code review
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>  - move library
>>  - Merge branch 'master' into JDK-8344942-TemplateFramework-v3
>>  - ... and 6 more: https://git.openjdk.org/jdk/compare/0844745e...fae7ced6
>
> test/hotspot/jtreg/testlibrary_tests/template_framework/examples/TestTutorial.java line 105:
> 
>> 103:             // Lists of Tokens are also allowed:
>> 104:             List.of("int ", "d = 5", ";\n"),
>> 105:             // That can be great for streaming / mapping over an existing list:
> 
> By "that" you just mean the following line? Maybe rephrase to: "We can also stream / map over an existing list or one created on the fly:

haha, now we kinda removed the list, since we are doing stream direclty. I think I will revert your suggestion here, back to `List.of().stream`, just to make clear that we can do all of that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2077510202


More information about the hotspot-compiler-dev mailing list