RFR: 8344942: Template-Based Testing Framework [v9]
Emanuel Peter
epeter at openjdk.org
Wed May 7 20:24:01 UTC 2025
On Wed, 7 May 2025 11:51:45 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' into JDK-8344942-TemplateFramework-v3
>> - Whitespace
>> - Suggestions by Christian
>>
>> Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>> - typo
>> - For Christian: example and more intro
>> - fix hashtag
>> - manual merge
>> - Apply suggestions from code review
>>
>> Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>> - move library
>> - Merge branch 'master' into JDK-8344942-TemplateFramework-v3
>> - ... and 6 more: https://git.openjdk.org/jdk/compare/0844745e...fae7ced6
>
> test/hotspot/jtreg/testlibrary_tests/template_framework/examples/TestTutorial.java line 61:
>
>> 59: CompileFramework comp = new CompileFramework();
>> 60:
>> 61: // Add java source files.
>
> Maybe it would also be nice to see the actually generated strings for the templates. Should we add an easy way to do this just for the tutorials in this file? Maybe we can do it by asking the user to pass an environment property like `-DPrintTemplates=true` or something like that. Or is there already a way provided by the framework to print the resulting templates on demand?
There is `-DCompileFrameworkVerbose=true`, which will print the code that the CompileFramework compiles. I think that would be good enough, right?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2078434343
More information about the hotspot-compiler-dev
mailing list