RFR: 8344942: Template-Based Testing Framework [v9]

Emanuel Peter epeter at openjdk.org
Wed May 7 20:54:53 UTC 2025


On Wed, 7 May 2025 20:44:11 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> I prefer multiline strings, but that does not always work. `\n` is just less of a disturbance.
>
> ![image](https://github.com/user-attachments/assets/51e6af52-a8de-4d1f-93fd-f89b910f1310)
> 
> Boah, I feel like this really looks quite unreadable / distracting. It makes the lines super long.
> 
> Makes me look for other "hacky" solutions. Maybe some `#\n` string, to make a hashtag replacement that gets you the newline / lineSeparator?
> 
> ![image](https://github.com/user-attachments/assets/226f7022-c799-4b04-867b-5233d8c9ee7c)
> That looks a little better.
> 
> This is what I used to have:
> ![image](https://github.com/user-attachments/assets/3035aacf-ca09-4f5d-868e-d92a0adf2d04)

Or should we just keep the `\n`, and wait until someone actually has an issue with it? Because on all of the platforms we run this on it works, even Windows where a lineSeparator() is supposed to be `\r\n`. And I'm a little hesitant to implement something heavy if we are not sure we really need it ;)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2078475551


More information about the hotspot-compiler-dev mailing list