RFR: 8356328: Some C2 IR nodes miss size_of() function [v2]

[Tobias Hartmann]

On Thu, 8 May 2025 06:47:14 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> kuaiwei has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add missing size_of() in machnode.hpp
>
> src/hotspot/share/opto/intrinsicnode.hpp line 201:
> 
>> 199:   virtual Node* Ideal(PhaseGVN* phase, bool can_reshape);
>> 200:   virtual const Type* Value(PhaseGVN* phase) const;
>> 201:   virtual uint size_of() const { return sizeof(EncodeISOArrayNode); }
> 
> Shouldn't nodes that define fields also override `Node::cmp` and `Node::hash`?

Ah, I see that Christian already asked that :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25081#discussion_r2079020465