RFR: 8356328: Some C2 IR nodes miss size_of() function [v2]
    Tobias Hartmann 
    thartmann at openjdk.org
       
    Thu May  8 12:19:51 UTC 2025
    
    
  
On Thu, 8 May 2025 12:01:58 GMT, kuaiwei <duke at openjdk.org> wrote:
>> Ah, I see that Christian already asked that :)
>
> I checked some nodes. `cmp/hash` are not always updated for new fields. It looks "nice to have". I have added `cmp/hash` for “EncodeISOArrayNode/ClearArrayNode/OpaqueMultiversioningNode" .
Thanks for doing that but it's not only nice to have, right? GVN might otherwise incorrectly common two different nodes.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25081#discussion_r2079603397
    
    
More information about the hotspot-compiler-dev
mailing list