RFR: 8351568: Improve source code documentation for PhaseCFG::insert_anti_dependences [v2]

[Daniel Lundén]

On Wed, 7 May 2025 14:31:57 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updates after reviews
>
> src/hotspot/share/opto/gcm.cpp line 779:
> 
>> 777:   ResourceArea* area = Thread::current()->resource_area();
>> 778: 
>> 779:   // Bookkeeping of possibly anti-dependent stores that we find outside of the
> 
> Suggestion:
> 
>   // Bookkeeping of possibly anti-dependent stores that we find below the

Technically, "outside of" is more appropriate here, because the stores that we bookkeep are not necessarily dominated by ("below") early. Since the search starts from `initial_mem`, which can be in a much earlier block than early, stores that we bookkeep can also be above early, or on completely distinct control-flow paths that do not even go through early. But, you are correct that only stores below early matter in the end.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24926#discussion_r2079940985