RFR: 8351568: Improve source code documentation for PhaseCFG::insert_anti_dependences [v5]

Daniel Lundén dlunden at openjdk.org
Fri May 9 18:10:09 UTC 2025


On Fri, 9 May 2025 17:02:06 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revise explanation of non_early_stores
>
> src/hotspot/share/opto/gcm.cpp line 786:
> 
>> 784:   // therefore, stores we find may be in blocks that are on completely distinct
>> 785:   // control-flow paths compared to early. However, in the end, only stores in
>> 786:   // blocks dominated by early matters. The reason for bookkeeping not only
> 
> Suggestion:
> 
>   // blocks dominated by early matter. The reason for bookkeeping not only

Ah, thanks. Updated!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24926#discussion_r2082244895


More information about the hotspot-compiler-dev mailing list