RFR: 8344942: Template-Based Testing Framework [v9]
Emanuel Peter
epeter at openjdk.org
Mon May 12 09:12:24 UTC 2025
On Wed, 7 May 2025 11:44:22 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' into JDK-8344942-TemplateFramework-v3
>> - Whitespace
>> - Suggestions by Christian
>>
>> Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>> - typo
>> - For Christian: example and more intro
>> - fix hashtag
>> - manual merge
>> - Apply suggestions from code review
>>
>> Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>> - move library
>> - Merge branch 'master' into JDK-8344942-TemplateFramework-v3
>> - ... and 6 more: https://git.openjdk.org/jdk/compare/0844745e...fae7ced6
>
> test/hotspot/jtreg/testlibrary_tests/template_framework/examples/TestTutorial.java line 98:
>
>> 96: System.out.println("Hello World!");
>> 97: """,
>> 98: "int a = ", Integer.valueOf(1), ";\n",
>
> Might be better to use `System.lineSeparator()` instead of `\n` to be platform independent.
@chhagedorn As discussed offline:
We figured out that text blocks also normalize newline to `\n`, see https://openjdk.org/jeps/378.
Since Templates will make heavy use of text blocks, it makes sense to just keep everything with `\n`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2084205369
More information about the hotspot-compiler-dev
mailing list