RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v64]

Vladimir Kozlov kvn at openjdk.org
Mon May 12 15:35:14 UTC 2025


On Mon, 5 May 2025 12:42:24 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

>> Hi,
>> 
>> This patch adds unsigned bounds and known bits constraints to TypeInt and TypeLong. This opens more transformation opportunities in an elegant manner as well as helps avoid some ad-hoc rules in Hotspot.
>> 
>> In general, a `TypeInt/Long` represents a set of values `x` that satisfies: `x s>= lo && x s<= hi && x u>= ulo && x u<= uhi && (x & zeros) == 0 && (x & ones) == ones`. These constraints are not independent, e.g. an int that lies in [0, 3] in signed domain must also lie in [0, 3] in unsigned domain and have all bits but the last 2 being unset. As a result, we must canonicalize the constraints (tighten the constraints so that they are optimal) before constructing a `TypeInt/Long` instance.
>> 
>> This is extracted from #15440 , node value transformations are left for later PRs. I have also added unit tests to verify the soundness of constraint normalization.
>> 
>> Please kindly review, thanks a lot.
>> 
>> Testing
>> 
>> - [x] GHA
>> - [x] Linux x64, tier 1-4
>
> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add more intn_t tests

This looks fine to me but to be on safe side lets push it into JDK 26 when it is forked.
And I don't see link in RFE to recent testing of this. It needs to be tested in all tiers including tier10, xcomp and stress.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17508#issuecomment-2873033620


More information about the hotspot-compiler-dev mailing list