RFR: 8356281: Fix for TestFPComparison failure due to incorrect result [v3]
    Srinivas Vamsi Parasa 
    sparasa at openjdk.org
       
    Mon May 12 22:46:11 UTC 2025
    
    
  
On Thu, 8 May 2025 16:54:10 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add TEMP(dst)
>
> src/hotspot/cpu/x86/x86_64.ad line 6273:
> 
>> 6271:   ins_cost(200);
>> 6272:   format %{ "ecmovpl  $dst, $src1, $src2\n\t"
>> 6273:             "cmovnel  $dst, $src2" %}
> 
> You need `effect(TEMP dst)` for these nodes, too.
Thank you! Please see the `effect(TEMP dst)` added for all the match rules.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25101#discussion_r2085634487
    
    
More information about the hotspot-compiler-dev
mailing list