RFR: 8325647: [IR framework] Only prints stdout if exitCode is 134 [v2]

Marc Chevalier mchevalier at openjdk.org
Tue May 13 16:06:52 UTC 2025


On Tue, 13 May 2025 11:38:25 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use Platform.isWindows
>
> test/hotspot/jtreg/compiler/lib/ir_framework/driver/TestVMProcess.java line 262:
> 
>> 260:         String stdErr = oa.getStderr();
>> 261:         String stdOut = "";
>> 262:         boolean osIsWindows = System.getProperty("os.name").toLowerCase().contains("windows");
> 
> You can use `Platform.isWindows()` instead.

Better, thanks. And replaced. (My implementation was actually pretty similar to `Platform.isWindows()`, there seems not to be a much nicer way, but only name matching.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25200#discussion_r2087178535


More information about the hotspot-compiler-dev mailing list