RFR: 8349563: Improve AbsNode::Value() for integer types [v2]
Damon Fenacci
dfenacci at openjdk.org
Wed May 14 07:31:58 UTC 2025
On Mon, 12 May 2025 02:32:49 GMT, Jasmine Karthikeyan <jkarthikeyan at openjdk.org> wrote:
>> Jasmine Karthikeyan has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>>
>> - Merge
>> - Improve AbsNode::Value
>
> Thank you all for the comments! I've pushed an update that refactors the method to check for `min_value` ahead of doing abs, so that we can safely use `ABS()` instead of `uabs()`. I've refactored the behavior for constants to avoid using `uabs` there as well. A re-review would be appreciated!
Thanks @jaskarth.
Running tier1-3 tests...
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23685#issuecomment-2879038589
More information about the hotspot-compiler-dev
mailing list