Integrated: 8325647: [IR framework] Only prints stdout if exitCode is 134

[Marc Chevalier]

On Tue, 13 May 2025 08:03:21 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:

> On Linux, `assert` and such eventually use `abort` which give the return code 134 (128 + 6 (code of SIGABRT/SIGIOT)). On Windows, dying returns `-1` (exit code are more-or-less-signed int on Windows):
> 
> https://github.com/openjdk/jdk/blob/2b3254160933e8b11527f801507a9c01b90d22b0/src/hotspot/os/windows/os_windows.cpp#L1382-L1384
> 
> So let's make the IR framework aware of this: we consider there was a JVM error if the OS is windows and the return code -1, or if it's 134 otherwise. I'm not sure what's the most idiomatic/robust way to check whether we are on Windows or not, but it's not customer code: it just needs to work for testing.

This pull request has now been integrated.

Changeset: 3b271981
Author:    Marc Chevalier <mchevalier at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3b271981662df2a7fdf04ffd75d017964425607c
Stats:     3 lines in 1 file changed: 2 ins; 0 del; 1 mod

8325647: [IR framework] Only prints stdout if exitCode is 134

Reviewed-by: chagedorn, thartmann

-------------

PR: https://git.openjdk.org/jdk/pull/25200