RFR: 8355585: Aarch64: Add aarch64 backend for Float16 vector operations [v2]
Bhavana Kilambi
bkilambi at openjdk.org
Wed May 14 08:09:53 UTC 2025
On Wed, 14 May 2025 00:59:44 GMT, Hao Sun <haosun at openjdk.org> wrote:
>> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Address review comments
>
> src/hotspot/cpu/aarch64/aarch64_vector_ad.m4 line 553:
>
>> 551:
>> 552: // vector add - predicated
>> 553: BINARY_OP_PREDICATE(vaddB, AddVB, sve_add, B)
>
> stylistic nit: remove the extra spaces.
>
> In the initial commit, this extra space is added due to `vaddHF`. However, in the latest commit the predicated Float16 rules are removed.
Good catch! I'll update a PS soon. Thanks!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25096#discussion_r2088333521
More information about the hotspot-compiler-dev
mailing list