RFR: 8344942: Template-Based Testing Framework [v9]
    Emanuel Peter 
    epeter at openjdk.org
       
    Wed May 14 08:27:17 UTC 2025
    
    
  
On Wed, 7 May 2025 11:59:48 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits:
>> 
>>  - Merge branch 'master' into JDK-8344942-TemplateFramework-v3
>>  - Whitespace
>>  - Suggestions by Christian
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>  - typo
>>  - For Christian: example and more intro
>>  - fix hashtag
>>  - manual merge
>>  - Apply suggestions from code review
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>  - move library
>>  - Merge branch 'master' into JDK-8344942-TemplateFramework-v3
>>  - ... and 6 more: https://git.openjdk.org/jdk/compare/0844745e...fae7ced6
>
> Next batch of comments. Will probably resume tomorrow :-)
@chhagedorn And I had discussed previously that it is nice to have the static methods like `let`, `body`, `$` etc under `Template`, but then not to use it for anything else. Sure, we could move the static methods under `TemplateUtils` or alike, if we really need to free up the name. But the bigger argument for me is really that `(Un)FilledTemplate` makes things very explicit.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24217#issuecomment-2879267349
    
    
More information about the hotspot-compiler-dev
mailing list