RFR: 8345485: C2 MergeLoads: merge adjacent array/native memory loads into larger load [v15]

[kuaiwei]

On Fri, 2 May 2025 10:16:56 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> kuaiwei has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix build error on mac and windows
>
> src/hotspot/share/opto/addnode.cpp line 975:
> 
>> 973: MergeLoadInfo MergePrimitiveLoads::merge_load_info(LoadNode* load) const {
>> 974:   const MergeLoadInfo invalid = MergeLoadInfo();
>> 975:   const Node* check = bypass_i2l(load);
> 
> What does `check` stand for? Might `load_use` be more descriptive?

It's a `LoadNode` or a `ConverI2L` which is unique output of the `Load`, I didn't find a good name, could I add comment to describe node type?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24023#discussion_r2088775699