RFR: 8344942: Template-Based Testing Framework [v16]

Manuel Hässig mhaessig at openjdk.org
Wed May 14 13:16:11 UTC 2025


On Wed, 14 May 2025 12:47:12 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   more documentation fixes
>
> test/hotspot/jtreg/compiler/lib/template_framework/Name.java line 40:
> 
>> 38:  * @param type The type with which we restrict {@link Template#weighNames} and {@link Template#sampleName}.
>> 39:  * @param mutable Defines if the name is considered mutable or immutable.
>> 40:  * @param weight The weight measured by {@link Template#weighNames} and according to which we sample with {@link Template#sampleName}.
> 
> Suggestion:
> 
>  * @param weight The weight measured by {@link Template#weightNames} and according to which we sample with {@link Template#sampleName}.

Perhaps documenting the weight limits might also be warranted since this constructor is used directly in tests?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2088865843


More information about the hotspot-compiler-dev mailing list