RFR: 8344942: Template-Based Testing Framework [v16]

[Emanuel Peter]

On Wed, 14 May 2025 13:33:55 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   more documentation fixes
>
> test/hotspot/jtreg/compiler/lib/template_framework/Template.java line 328:
> 
>> 326:     /**
>> 327:      * Retrieves the dollar replacement of the {@code 'name'} for the
>> 328:      * current Template that is being instanciated. It returns the same
> 
> Suggestion:
> 
>      * current Template that is being instantiated. It returns the same

Manuel also suggested it :)

> test/hotspot/jtreg/testlibrary_tests/template_framework/examples/TestAdvanced.java line 96:
> 
>> 94:         // - For a chosen type, operator, and generator.
>> 95:         // - The variable name "GOLD" and the test name "test" would get conflicts
>> 96:         //   if we instanciate the template multiple times. Thus, we use the $ prefix
> 
> Suggestion:
> 
>         //   if we instantiate the template multiple times. Thus, we use the $ prefix

Manuel also suggested it :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2089082778
PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2089082333