RFR: 8344942: Template-Based Testing Framework [v17]

[Emanuel Peter]

On Wed, 14 May 2025 13:13:08 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review suggestions by Roberto
>>   
>>   Co-authored-by: Roberto Castañeda Lozano <robcasloz at users.noreply.github.com>
>
> Thank you, Emanuel, for working on this! I'm already looking forward to using it.
> 
> I did a superficial pass to get an overview and gain understanding. Apart from some typos, my main concern is reproducability with the randomness introduced in `NameSet`.

@mhaessig I applied all your suggestions!

@robcasloz I applied everything, except in https://github.com/openjdk/jdk/pull/24217#discussion_r2088927510 I did not. If you still want me to do it, we can continue discussing :)

------------

Offline, we have spent quite a lot of time discussing the naming of the Template, i.e. my original `Template(WithArgs)` 
vs what we have now `(Un)FilledTemplate`, or further alternatives.

The best suggestion so far is `TemplateWithFreeArgs` for one/two/three args where the args are not yet applied, and `RenderableTemplate` for zero, and one/two/three with applied args. We are still discussing what the transition name should be, best options so far: `with`, `withArgs`, `applyArgs`, `apply`.

As explained offline: making this renaming is surprisingly time consuming, so I will only do it once I get the final approval from you both @chhagedorn @robcasloz , and maybe even @mhaessig :)

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24217#issuecomment-2880614203