RFR: 8344942: Template-Based Testing Framework [v16]

[Roberto Castañeda Lozano]

On Wed, 14 May 2025 14:48:01 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/lib/template_framework/Template.java line 461:
>> 
>>> 459:      * @param name The {@link Name} to be added to the current code frame.
>>> 460:      * @return The token that performs the defining action.
>>> 461:      */
>> 
>> The concept of "code frame" is not clear here, maybe you can introduce it or replace it by a concept that is already defined?
>
> I specified it a little:
> 
> ~ 453      * Add a {@link Name} in the current scope, i.e. the innermost of either
> + 454      * {@link Template#body} or {@link Hook#set}.

Thanks, "scope" works better!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2090659990