RFR: 8351568: Improve source code documentation for PhaseCFG::insert_anti_dependences [v6]

Daniel Lundén dlunden at openjdk.org
Thu May 15 11:48:55 UTC 2025


On Thu, 15 May 2025 11:39:20 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> For consistency, we would need to then also change "the LCA" to "the load's LCA" in many more places throughout the method, which increases verbosity. Is it not OK to simply use "LCA", since we have defined that this is the load's LCA at the start? We don't mention any other LCAs, so I don't think there'll be any confusion.
>
> I matched that with the comment suggestion earlier but you changed that now to a better version. So, I agree with you here, let's leave it as it is :-)

Ah, I see. Good!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24926#discussion_r2090979211


More information about the hotspot-compiler-dev mailing list