RFR: 8355488: Add stress mode for C2 loop peeling [v3]
Christian Hagedorn
chagedorn at openjdk.org
Thu May 15 13:51:54 UTC 2025
On Thu, 15 May 2025 13:18:15 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
>> Marc Chevalier has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Back to PRODUCT for consistency
>
> src/hotspot/share/opto/loopnode.hpp line 137:
>
>> 135:
>> 136: #ifndef PRODUCT
>> 137: uint _peeling_opportunities_count = 0;
>
> I think this should rather be named `_stress_peeling_attempts` or something.
I thought about proposing "attempts" as well. But it sounds like we are actually trying loop peeling and then somehow fail which is not the case here - we just flipped a coin and then decided not to do peeling. Anyway, I don't have a strong opinion here :-)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25140#discussion_r2091222142
More information about the hotspot-compiler-dev
mailing list