RFR: 8356813: Improve Mod(I|L)Node::Value

Hannes Greule hgreule at openjdk.org
Thu May 15 18:10:51 UTC 2025


On Thu, 15 May 2025 17:47:16 GMT, Quan Anh Mai <qamai at openjdk.org> wrote:

> > Using `Type(Int|Long)::ZERO` instead (zero is always in the resulting value if we cover a range).
> 
> Can we return `Type::TOP` instead?

That should work too and might be more intuitive. I assume there also isn't much benefit in constant-folding users of the mod if the mod is known to fail (which seems to be the only benefit of not returning TOP?).

> Besides, #17508 should be merged right after JDK-25 folk, do you want to wait for it first?

We can wait if it makes sense to do the unsigned variants here too, but I'm also fine with doing it separately.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25254#issuecomment-2884668466


More information about the hotspot-compiler-dev mailing list