RFR: 8356328: Some C2 IR nodes miss size_of() function [v4]

[kuaiwei]

On Thu, 15 May 2025 13:36:41 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> kuaiwei has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove cmp()/hash() for Opaque node
>
> src/hotspot/share/opto/intrinsicnode.hpp line 202:
> 
>> 200:   virtual const Type* Value(PhaseGVN* phase) const;
>> 201:   virtual uint size_of() const { return sizeof(EncodeISOArrayNode); }
>> 202:   virtual uint hash() const { return Node::hash() + ascii; }
> 
> Was like that before but since you're touching the code now, can you also add a leading `_` for the `ascii` field?

Fixed

> src/hotspot/share/opto/machnode.hpp line 546:
> 
>> 544: 
>> 545: private:
>> 546:   bool _do_polling;
> 
> While touching this class, maybe move this field declaration up to the start of the class.

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25081#discussion_r2092329048
PR Review Comment: https://git.openjdk.org/jdk/pull/25081#discussion_r2092329150