RFR: 8344942: Template-Based Testing Framework [v25]

[Emanuel Peter]

On Thu, 15 May 2025 14:06:10 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix typo
>
> test/hotspot/jtreg/compiler/lib/template_framework/Template.java line 255:
> 
>> 253:          *
>> 254:          * @param a The value for the (first) argument.
>> 255:          * @return The template its argument applied.
> 
> Suggestion:
> 
>          * @return The template with its argument applied.

Changed the wording completely, because we now return a `TemplateToken` :)

> test/hotspot/jtreg/compiler/lib/template_framework/Template.java line 303:
> 
>> 301:          * @param a The value for the first argument.
>> 302:          * @param b The value for the second argument.
>> 303:          * @return The template all (two) arguments applied.
> 
> Suggestion:
> 
>          * @return The template with all (two) arguments applied.

Changed the wording completely, because we now return a `TemplateToken` :)

> test/hotspot/jtreg/compiler/lib/template_framework/Template.java line 378:
> 
>> 376:          * @param b The value for the second argument.
>> 377:          * @param c The value for the third argument.
>> 378:          * @return The template all (three) arguments applied.
> 
> Suggestion:
> 
>          * @return The template with all (three) arguments applied.

Changed the wording completely, because we now return a `TemplateToken` :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2092421485
PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2092421397
PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2092421326