RFR: 8356778: Compiler add event logging in case of failures
Matthias Baesken
mbaesken at openjdk.org
Fri May 16 08:18:52 UTC 2025
On Thu, 15 May 2025 20:30:10 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:
>> I could live with the check, but we get other problems when it is nullptr because nullptr is interpreted as no bailout!
>> `bool bailed_out() const { return _bailout_msg != nullptr; }`
>
> OK, with that knowledge and without the check, we crash when we try to log the null message. Otherwise, we crash or fail sometime later - or some strange things happen.
>
> If we follow the "fail early" principle, the additional check should not be there. We could as well convert the assert into a guarantee to enforce a "planned" crash.
okay I will remove the additional check , I think I saw the assert and thought , let's better do a check here to be on the safe side.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25188#discussion_r2092568243
More information about the hotspot-compiler-dev
mailing list