RFR: 8344942: Template-Based Testing Framework [v29]

[Emanuel Peter]

On Fri, 16 May 2025 07:08:02 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/lib/template_framework/Template.java line 88:
>> 
>>> 86:  * To get an executable test, we define a Template that produces a class body with a main method. The Template
>>> 87:  * takes a list of types, and calls the {@code testTemplate} defined above for each type and operator. We use
>>> 88:  * the {@code TestFramework} to call our {@code @Test} methods.
>> 
>> For the first mention, you can also add a link:
>> Suggestion:
>> 
>>  * the {@link TestFramework} to call our {@code @Test} methods.
>> 
>> Also requires:
>> 
>> import compiler.lib.ir_framework.TestFramework;
>
> Just a side note, maybe it's time to bite the bullet and finally rename `TestFramework` to `IRFramework` given that we have many frameworks now designed for tests... :shrug:

I don't know if that is really necessary. It already does more than "IR checks":
- It finds all test methods `@Test`
- helps with `@Setup` etc.
- And I hope one day we can put in automatic result verification as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2092725980