RFR: 8344942: Template-Based Testing Framework [v30]

Emanuel Peter epeter at openjdk.org
Fri May 16 10:03:03 UTC 2025


On Fri, 16 May 2025 08:46:48 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   apply offline suggestions by Christian
>
> test/hotspot/jtreg/compiler/lib/template_framework/Template.java line 620:
> 
>> 618:      * nesting level, and once the {@link #fuel} reaches zero, the nesting is supposed to terminate.
>> 619:      */
>> 620:     public final static float DEFAULT_FUEL_COST = 10.0f;
> 
> Suggestion:
> 
>     float DEFAULT_FUEL = 100.0f;
> 
>     /**
>      * The default amount of fuel spent per Template. It is subtracted from the current {@link #fuel} at every
>      * nesting level, and once the {@link #fuel} reaches zero, the nesting is supposed to terminate.
>      */
>     float DEFAULT_FUEL_COST = 10.0f;

removed the `public final static`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2092747498


More information about the hotspot-compiler-dev mailing list