RFR: 8344942: Template-Based Testing Framework [v32]

[Emanuel Peter]

On Fri, 16 May 2025 12:02:29 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix up review suggestions
>
> Some more comments, I will take this up again on Monday. Looking good so far :-) Great work!

@chhagedorn Thanks for all the suggestions, we are making good progress!

I have just added a test for subtype use of Names, and will improve the tutorial with some more cases now.

> test/hotspot/jtreg/compiler/lib/template_framework/CodeFrame.java line 36:
> 
>> 34:  * {@link Hook}s can be added to a frame, which allows code to be inserted at that location later.
>> 35:  * When a {@link Hook} is {@link Hook#set}, this separates the Template into an outer and inner
>> 36:  * {@link CodeFrame}, ensuring that names that are {@link Template#defineName}'d inside the inner frame
> 
> `define` and `defineName` seem to no longer exist.

Ah, refactoring artifact. Should be `addName`. Fixed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24217#issuecomment-2886588658
PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2092952214