RFR: 8356328: Some C2 IR nodes miss size_of() function [v5]

duke duke at openjdk.org
Sat May 17 05:26:57 UTC 2025


On Fri, 16 May 2025 05:12:38 GMT, kuaiwei <duke at openjdk.org> wrote:

>> I wrote a test to check if every C2 IR node has correct size_of() function. And I found some of them are missed. They added new fields and not add size_of() to reflect new size. In linux, it does not cause issue so far, because gcc allocate more space for alignment and can keep these additional `bool` flags. But it will report failure on windows. And if anyone modified base class, it will cause problem.
>> 
>> PS, My test is in https://github.com/openjdk/jdk/compare/master...kuaiwei:jdk:test/check_node_size , but it has many hack on IR nodes to make test to run.
>
> kuaiwei has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Minor change

@kuaiwei 
Your change (at version 08debbd75d35fc52c0738eaec876411b2e42d51c) is now ready to be sponsored by a Committer.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25081#issuecomment-2888098202


More information about the hotspot-compiler-dev mailing list