RFR: 8355574: Fatal error in abort_verify_int_in_range due to Invalid CastII [v4]

Quan Anh Mai qamai at openjdk.org
Sun May 18 07:06:41 UTC 2025


> Hi,
> 
> The issue here is that the `CastLLNode` is created before the actual check that ensures the range of the input. This patch fixes it by moving the creation to the correct place, which is under `inline_block`. I also noticed that the code there seems incorrect and confusing. `ArrayCopyNode::get_partial_inline_vector_lane_count` takes the length of the array, not the size in bytes. If you look into the method it will multiply `const_len` with `type2aelementbytes(bt)` to get the size in bytes of the array. In the runtime test, we compare `length << log2(type2bytes(bt))` with `ArrayOperationPartialInlineSize`. This seems confusing, why don't we just compare `length` with `ArrayOperationPartialInlineSize / type2bytes(bt)`, it also unifies the test with the actual cast.
> 
> Please take a look and leave your reviews, thanks a lot.

Quan Anh Mai has updated the pull request incrementally with two additional commits since the last revision:

 - fix comment
 - fix comment

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25284/files
  - new: https://git.openjdk.org/jdk/pull/25284/files/72e72180..fdbb88bd

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25284&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25284&range=02-03

  Stats: 4 lines in 2 files changed: 0 ins; 1 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/25284.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25284/head:pull/25284

PR: https://git.openjdk.org/jdk/pull/25284


More information about the hotspot-compiler-dev mailing list