RFR: 8342692: C2: long counted loop/long range checks: don't create loop-nest for short running loops [v16]
Emanuel Peter
epeter at openjdk.org
Mon May 19 09:11:01 UTC 2025
On Fri, 9 May 2025 12:38:03 GMT, Roland Westrelin <roland at openjdk.org> wrote:
>>> Interesting work and results with the benchmark! I have a few comments. Will have another look again later.
>>
>> Thanks for reviewing this @chhagedorn
>> I think new commit addresses all your comments.
>
>> @rwestrel Sorry it took so long for me to look at this.
>>
>> Did you do some benchmarking to prove that `ShortLoopIter = 1000` is reasonable?
>
> As mentioned in one of my replies to your questions, I removed that command line argument.
>
>> The Benchmark you published earlier does not seem to do that, right? [#21630 (comment)](https://github.com/openjdk/jdk/pull/21630#issuecomment-2587016221)
>>
>> I would also like to see that benchmark integrated. If you are using a benchmark to demonstrate the performance, it should be integrate so others can easily verify on their platform :)
>
> Right. But it's Maurizio's benchmark. I think it would make sense to integrate it separately. What do you think @mcimadamore ?
@rwestrel You could add the benchmark and add @mcimadamore as a contributor :)
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21630#issuecomment-2890236505
More information about the hotspot-compiler-dev
mailing list