RFR: 8327963: C2: fix construction of memory graph around Initialize node to prevent incorrect execution if allocation is removed [v5]
Galder Zamarreño
galder at openjdk.org
Mon May 19 12:23:53 UTC 2025
On Thu, 15 May 2025 12:33:18 GMT, Roland Westrelin <roland at openjdk.org> wrote:
>> src/hotspot/share/opto/library_call.cpp line 5554:
>>
>>> 5552: if (proj->_con == TypeFunc::Memory) {
>>> 5553: int alias_idx = C->get_alias_index(proj->adr_type());
>>> 5554: assert(alias_idx == Compile::AliasIdxRaw || alias_idx == elemidx || alias_idx == mark_idx || alias_idx == klass_idx, "should be raw memory or array element type");
>>
>> Shouldn't this `assert` be wrapped around an `#ifdef ASSERT` section?
>
> `assert` is a nop if `ASSERT` not defined. Does that answer your question?
Yup, thanks
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24570#discussion_r2095585908
More information about the hotspot-compiler-dev
mailing list