RFR: 8356813: Improve Mod(I|L)Node::Value
Hannes Greule
hgreule at openjdk.org
Mon May 19 16:03:58 UTC 2025
On Mon, 19 May 2025 08:58:37 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:
> The original code probably returned TypeInt::POS for the same reason you bring up below:
I doubt that, as it doesn't account for the sign of the dividend at all here. We also can't keep the existing behavior (see the section about monotonicity in the PR description).
>From my understanding, the node should also be kept alive no matter the value due to its control input.
I'll test with returning TOP.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25254#discussion_r2096056366
More information about the hotspot-compiler-dev
mailing list