RFR: 8344942: Template-Based Testing Framework [v16]

Emanuel Peter epeter at openjdk.org
Tue May 20 14:41:05 UTC 2025


On Wed, 14 May 2025 13:40:02 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   more documentation fixes
>
> A few more documentation suggestions, will continue reviewing this changeset over the next days.

@robcasloz Thanks for your review suggestion, I will address them shortly.

I have just pushed the `DataName / StructuralName` refactor that I had discussed with @chhagedorn and @mhaessig .

There are still a few smaller things missing:
- A test for adding names with weights that are too small or too large -> expect exception.
- Duplicate tests I have for `DataName`, so that we also test `StructuralName` sufficiently.
- More examples with how `DataName` interacts with `Hook.insert`.
- Renaming `Hook.set` to `Hook.anchor`
- Verify that there is no duplication of names with the same `name()`, both up and down the scopes.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24217#issuecomment-2894670454


More information about the hotspot-compiler-dev mailing list