RFR: 8351994: Enable Extended EVEX to REX2/REX demotion when src and dst are the same [v27]

Srinivas Vamsi Parasa sparasa at openjdk.org
Tue May 20 16:31:06 UTC 2025


On Sun, 18 May 2025 01:31:14 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Srinivas Vamsi Parasa has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update x86-asmtest.py to enable demotion by default and make test generation optional
>
> src/hotspot/cpu/x86/assembler_x86.cpp line 13002:
> 
>> 13000: }
>> 13001: 
>> 13002: int Assembler::evex_prefix_and_encode_ndd(int dst_enc, int nds_enc, VexSimdPrefix pre, VexOpcode opc,
> 
> Suggestion:
> 
> int Assembler::emit_eevex_prefix_or_demote_ndd(int dst_enc, int nds_enc, VexSimdPrefix pre, VexOpcode opc,
> 
> 
> Nameing suggetion

There are different overloaded functions with the name evex_prefix_and_encode_ndd. Just want to confirm that this renaming suggestion must be applied to all of them with the same name (which also do demotion), right?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24431#discussion_r2098403723


More information about the hotspot-compiler-dev mailing list