RFR: 8357250: assert(shift >= 0 && shift < 4) failed: unexpected compressd klass shift! [v2]

[Martin Doerr]

On Tue, 20 May 2025 15:27:32 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Several fixes for AOT code generation:
>>   - Use `CompressedKlassPointers::max_shift()` in asserts to take into account  Compact Object Headers (the asserts are present only in aarch64 code)
>>   - Increase table stub size on aarch64 when AOT specialized code is used for klass decoding (hit assert there otherwise)
>>   - Fix "copy-paste" typo in `RelocIterator()` which incorrectly overwrite the start address of instruction section (restored relocations in AOTed exception blob was wrong and AOT tests failed when deoptimization happened)
>>   - Removed `vm.flagless` from AOT code tests to increase testing coverage (otherwise they were run only in tier1)
>>   - Add additions `@requires` to tests for expected execution configuration
>> 
>> Tested hs-tier1-10, Xcomp, stress
>
> Vladimir Kozlov has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Update src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp
>    
>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>
>  - Update src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp
>    
>    Co-authored-by: Tobias Hartmann <tobias.hartmann at oracle.com>

LGTM and tier1-2 have passed on MacOS aarch64. Thanks for fixing it!

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25330#pullrequestreview-2855447162