RFR: 8357056: RISC-V: Asm fixes - load/store width [v2]
Fei Yang
fyang at openjdk.org
Wed May 21 03:03:54 UTC 2025
On Tue, 20 May 2025 12:02:43 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> Hi, please consider.
>>
>> While working on https://github.com/openjdk/jdk/pull/25252, I notice:
>> - Major op code was just repeat
>> - Width coded in binary
>> - Stores have mixed up rs1 and rs2
>> - Bonus, fsd used a macro for no reason
>>
>> I think this improves readability.
>>
>> Tested tier1
>>
>> Thanks, Robbin
>
> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Fixed flh/flw/fld
> - Merge branch 'master' into asm_fixes
> - Fixes
Latest version looks great! Thanks.
-------------
Marked as reviewed by fyang (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/25253#pullrequestreview-2856098290
More information about the hotspot-compiler-dev
mailing list