RFR: 8342692: C2: long counted loop/long range checks: don't create loop-nest for short running loops [v22]

[Roland Westrelin]

On Mon, 19 May 2025 08:10:14 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request incrementally with 11 additional commits since the last revision:
>> 
>>  - Update src/hotspot/share/opto/loopnode.cpp
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>  - Update src/hotspot/share/opto/graphKit.cpp
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>  - Update src/hotspot/share/opto/castnode.cpp
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>  - Update src/hotspot/share/opto/loopnode.hpp
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>  - Update src/hotspot/share/opto/loopnode.hpp
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>  - Update src/hotspot/share/opto/loopnode.cpp
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>  - Update src/hotspot/share/opto/loopnode.cpp
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>  - Update src/hotspot/share/opto/loopnode.cpp
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>  - Update src/hotspot/share/opto/loopnode.cpp
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>  - Update src/hotspot/share/opto/loopnode.cpp
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>>  - ... and 1 more: https://git.openjdk.org/jdk/compare/b0129598...2164c15f
>
> src/hotspot/share/opto/loopnode.hpp line 219:
> 
>> 217: 
>> 218:   virtual void set_trip_count(julong tc) = 0;
>> 219:   virtual julong trip_count() = 0;
> 
> GitHub Actions seems to disagree with something here ;)
> 
> /home/runner/work/jdk/jdk/src/hotspot/share/opto/loopnode.hpp:219:18: error: ‘virtual julong BaseCountedLoopNode::trip_count()’ was hidden [-Werror=overloaded-virtual]
>   219 |   virtual julong trip_count() = 0;
>       |                  ^~~~~~~~~~
> /home/runner/work/jdk/jdk/src/hotspot/share/opto/loopnode.hpp:310:10: note:   by ‘julong CountedLoopNode::trip_count() const’
>   310 |   julong trip_count() const      { return _trip_count; }
>       |          ^~~~~~~~~~

Right. I wasn't done with @chhagedorn 's review. I was waiting for the answer to: https://github.com/openjdk/jdk/pull/21630#discussion_r2091476799
I pushed those changes now (but I still Christian to clarify his comment)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21630#discussion_r2099606003