RFR: 8344942: Template-Based Testing Framework [v16]
Emanuel Peter
epeter at openjdk.org
Wed May 21 15:37:04 UTC 2025
On Tue, 20 May 2025 17:06:34 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:
>> A few more documentation suggestions, will continue reviewing this changeset over the next days.
>
>> @robcasloz I addressed all your comments :)
>
> Thanks @eme64!
Especially thanks for doing some hands-on testing, which brought up the necessity of `#{name}` for cases like `#{TYPE}_CON`, where `#TYPE_CON` did not work nicely, because it uses the name `TYPE_CON` rather than `TYPE`, which would have required an additional `let` definition.
Manuel and Christian have spend a few hours in offline meetings by now, and made a lot of good suggestions. It was hard work, but it has payed off, I'm very thankful 😊
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24217#issuecomment-2898393162
More information about the hotspot-compiler-dev
mailing list