RFR: 8357056: RISC-V: Asm fixes - load/store width [v3]

[Hamlin Li]

On Thu, 22 May 2025 06:56:36 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Hi, please consider.
>> 
>> While working on https://github.com/openjdk/jdk/pull/25252, I notice:
>> - Major op code was just repeat
>> - Width coded in binary
>> - Stores have mixed up rs1 and rs2
>> - Bonus, fsd used a macro for no reason
>> 
>> I think this improves readability.
>> 
>> Tested tier1
>> 
>> Thanks, Robbin
>
> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
> 
>  - Rd/Rs->Rs2/Rs1
>  - Merge branch 'master' into asm_fixes
>  - Fixed flh/flw/fld
>  - Merge branch 'master' into asm_fixes
>  - Fixes

I think the original rd/rs is easier to understand the meaning of the parameters. Although the changed one is consistent with the specification, it seems to me that it is more error-prone to use it, maybe it's just my feeling?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25253#issuecomment-2900157056