RFR: 8357056: RISC-V: Asm fixes - load/store width [v3]
Hamlin Li
mli at openjdk.org
Thu May 22 10:41:54 UTC 2025
On Thu, 22 May 2025 06:56:36 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> Hi, please consider.
>>
>> While working on https://github.com/openjdk/jdk/pull/25252, I notice:
>> - Major op code was just repeat
>> - Width coded in binary
>> - Stores have mixed up rs1 and rs2
>> - Bonus, fsd used a macro for no reason
>>
>> I think this improves readability.
>>
>> Tested tier1
>>
>> Thanks, Robbin
>
> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - Rd/Rs->Rs2/Rs1
> - Merge branch 'master' into asm_fixes
> - Fixed flh/flw/fld
> - Merge branch 'master' into asm_fixes
> - Fixes
Marked as reviewed by mli (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/25253#pullrequestreview-2860726465
More information about the hotspot-compiler-dev
mailing list