RFR: 8327963: C2: fix construction of memory graph around Initialize node to prevent incorrect execution if allocation is removed [v7]

Roland Westrelin roland at openjdk.org
Thu May 22 15:20:20 UTC 2025


On Wed, 21 May 2025 10:11:50 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Roland Westrelin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 33 additional commits since the last revision:
>> 
>>  - new test tweak
>>  - new test
>>  - Merge branch 'master' into JDK-8327963
>>  - Merge branch 'master' into JDK-8327963
>>  - typo
>>  - more
>>  - more
>>  - more
>>  - more
>>  - more
>>  - ... and 23 more: https://git.openjdk.org/jdk/compare/ab166f28...a6c6c044
>
> test/hotspot/jtreg/compiler/macronodes/TestEarlyEliminationOfAllocationWithoutUse.java line 54:
> 
>> 52:     private static void test1(A otherA, boolean[] flags) {
>> 53:         if (flags == null) {
>> 54:         }
> 
> Consider removing these two lines, which do not seem essential to reproduce the issue. Removing them also gets rid of the deoptimization, which simplifies the failure analysis.

Good catch. Done in new commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24570#discussion_r2102822733


More information about the hotspot-compiler-dev mailing list