RFR: 8357568: IGV: Show NULL and numbers up to 4 characters in "Condense graph" filter [v2]
Kim Barrett
kbarrett at openjdk.org
Thu May 22 18:08:52 UTC 2025
On Thu, 22 May 2025 14:44:07 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> When using the "Condense graph" filter in IGV, it would be useful to show `NULL` and numbers wider than 2 characters instead of `P` and `I/L` (fallback for larger numbers), respectively. There is a comment in `idealGrapPrinter.cpp` which says that maximally 2 chars are allowed for numbers:
>> https://github.com/openjdk/jdk/blob/428d33ef3ca0af34d8f164fe9d9b722e81e866a7/src/hotspot/share/opto/idealGraphPrinter.cpp#L646
>>
>> But we already allow larger entries today:
>> 
>>
>> I there propose to use `NULL` and allow up to 4 characters for numbers which could be a good trade-off between shortness and expressiveness. This allows us to quickly see null checks and larger constants.
>>
>> Without patch:
>> 
>>
>>
>> With patch:
>> 
>>
>> Thanks,
>> Christian
>
> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>
> Increase number of parameters as suggested by Manuel
src/hotspot/share/opto/idealGraphPrinter.cpp line 676:
> 674: } else if (t->base() == Type::AnyPtr) {
> 675: if (t->is_ptr()->ptr() == TypePtr::Null) {
> 676: print_prop(short_name, "NULL");
I'm surprised this doesn't trip over sources/TestNoNULL.java.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25393#discussion_r2103131624
More information about the hotspot-compiler-dev
mailing list