RFR: 8357568: IGV: Show NULL and numbers up to 4 characters in "Condense graph" filter [v2]

[Tobias Hartmann]

On Thu, 22 May 2025 18:05:54 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Increase number of parameters as suggested by Manuel
>
> src/hotspot/share/opto/idealGraphPrinter.cpp line 676:
> 
>> 674:       } else if (t->base() == Type::AnyPtr) {
>> 675:         if (t->is_ptr()->ptr() == TypePtr::Null) {
>> 676:           print_prop(short_name, "NULL");
> 
> I'm surprised this doesn't trip over sources/TestNoNULL.java.

Actually it does, see failures in github actions testing:
> Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Test found 1 usages of 'NULL' in source files. See errors above.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25393#discussion_r2103968467