RFR: 8357568: IGV: Show NULL and numbers up to 4 characters in "Condense graph" filter [v3]
Christian Hagedorn
chagedorn at openjdk.org
Fri May 23 09:07:17 UTC 2025
> When using the "Condense graph" filter in IGV, it would be useful to show `NULL` and numbers wider than 2 characters instead of `P` and `I/L` (fallback for larger numbers), respectively. There is a comment in `idealGrapPrinter.cpp` which says that maximally 2 chars are allowed for numbers:
> https://github.com/openjdk/jdk/blob/428d33ef3ca0af34d8f164fe9d9b722e81e866a7/src/hotspot/share/opto/idealGraphPrinter.cpp#L646
>
> But we already allow larger entries today:
> 
>
> I there propose to use `NULL` and allow up to 4 characters for numbers which could be a good trade-off between shortness and expressiveness. This allows us to quickly see null checks and larger constants.
>
> Without patch:
> 
>
>
> With patch:
> 
>
> Thanks,
> Christian
Christian Hagedorn has updated the pull request incrementally with one additional commit since the last revision:
better way to check nof chars, also print narrow oop null
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/25393/files
- new: https://git.openjdk.org/jdk/pull/25393/files/4f77d003..c4381a03
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=25393&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=25393&range=01-02
Stats: 7 lines in 1 file changed: 2 ins; 0 del; 5 mod
Patch: https://git.openjdk.org/jdk/pull/25393.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/25393/head:pull/25393
PR: https://git.openjdk.org/jdk/pull/25393
More information about the hotspot-compiler-dev
mailing list