RFR: 8357473: Compilation spike leaves many CompileTasks in free list
Vladimir Kozlov
kvn at openjdk.org
Fri May 23 16:06:52 UTC 2025
On Fri, 23 May 2025 09:42:17 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> See bug for more discussion.
>
> This PR implements the "all the way" solution by removing the free list completely. It complements https://github.com/openjdk/jdk/pull/25364, and can go either first, or second. We will remerge the other one once either integrates.
>
> Additional testing:
> - [x] Linux x86_64 server fastdebug, `compiler`
> - [ ] Linux AArch64 server fastdebug, `all`
Did you do performance compare?
src/hotspot/share/compiler/compileTask.cpp line 81:
> 79:
> 80: CompileTask::~CompileTask() {
> 81: assert(!lock()->is_locked(), "Should not be locked when freed");
Do we need to free `_lock` ?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25409#issuecomment-2904951634
PR Review Comment: https://git.openjdk.org/jdk/pull/25409#discussion_r2104908263
More information about the hotspot-compiler-dev
mailing list