RFR: 8290892: C2: Intrinsify Reference.reachabilityFence [v3]

[Vladimir Ivanov]

On Fri, 23 May 2025 07:24:38 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> IMO it doesn't clarify things much. It's enum constant name and it's not shown in IGV.
>> 
>> It is used in a single place [1] where it's clear what it refers to. 
>> 
>> [1]
>> 
>>   { // No more loop opts. It is safe to eliminate reachability fence nodes.
>>     TracePhase tp(_t_idealLoop);
>>     PhaseIdealLoop::optimize(igvn, LoopOptsEliminateRFs);
>>     print_method(PHASE_OPTIMIZE_RF, 2);
>>     if (failing())  return;
>>   }
>
> That's a good point, there it really does not matter. Another thought I've just had: When you add it to the `CompilePhase` class in the IR framework and it would be nice to have the same name. There, it would be beneficial to have the full name since people then only see `CompilePhase::OPTIMIZE_RF`.

That's fair. Renamed and added to `CompilePhase.java`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25315#discussion_r2105497776