RFR: 8355574: Fatal error in abort_verify_int_in_range due to Invalid CastII [v4]

[Quan Anh Mai]

On Sat, 24 May 2025 01:46:25 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - fix comment
>>  - fix comment
>
> src/hotspot/share/opto/macroArrayCopy.cpp line 209:
> 
>> 207:   int inline_limit = ArrayOperationPartialInlineSize / type2aelembytes(type);
>> 208: 
>> 209:   const TypeLong* length_type = _igvn.type(length)->isa_long();
> 
> Any particular benefit in eagerly pruning the block? It duplicates post-expansion GVN checks of the branch condition. (If it were normal parsing with prompt GVN analysis, you could detect the branch is dead right after `generate_guard` call.) 
> 
> Alternatively, the checks are equivalent to checking that join of `length_type` with `[0...inline_limit]` is not empty. But I prefer to let GVN handle it.

I think it is a trivial check and it is much more efficient than creating a bunch of nodes and removing them later.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25284#discussion_r2105761153